Skip to content

Relax keyframe selectors #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tj merged 1 commit into from
Sep 17, 2013
Merged

Relax keyframe selectors #52

tj merged 1 commit into from
Sep 17, 2013

Conversation

@jo
Copy link

@jo jo commented Sep 16, 2013

The changes adds the ability to parse basic Skrollr Stylesheets.

It allows numerical keyframes-selectors and easing function syntax, eg:

@-skrollr-keyframes one {
    top {
        left: 100%;
        opacity[swing]: 0.0;
    }
    100 {
        left: 10%;
        opacity: 0.5;
    }
    bottom {
        left: 0%;
        opacity: 1.0;
    }
}
  • numerical keyframes-selectors
  • top, bottom keyframes-selectors
  • easing function syntax

@jo jo mentioned this pull request Sep 16, 2013
Closed
@tj
Copy link
Member

tj commented Sep 16, 2013

I don't really want to make up syntax at the css-parse level

@jo
Copy link
Author

jo commented Sep 16, 2013

I was kind of doubtfully, too, but I think its just about relaxing the parser a bit.

@tj
Copy link
Member

tj commented Sep 16, 2013

yeah could be worse haha, a few tests would be good

Relax keyframe selectors and property names
d86f9cd 
Support Skrollr Stylesheets, allow
* numerical keyframes-selectors
* generic alphanumeric keyframes-selectors (`top`)
* propertys with `[word]`
@jo
Copy link
Author

jo commented Sep 16, 2013

ok I squashed the commits and added some tests

@tj
Copy link
Member

tj commented Sep 17, 2013

awesome! thanks

tj added a commit that referenced this pull request Sep 17, 2013
@tj
Merge pull request #52 from null2/master
b3042ce 
Relax keyframe selectors
@tj tj merged commit b3042ce into reworkcss:master Sep 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jo @tj